FEAT: Draft_filtersolutions #4745
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4745 +/- ##
==========================================
- Coverage 83.14% 81.14% -2.01%
==========================================
Files 118 130 +12
Lines 54075 55970 +1895
==========================================
+ Hits 44959 45415 +456
- Misses 9116 10555 +1439 |
There was a problem hiding this comment.
I haven't reviewed all files yet, but had some initial comments. I would also like to get input from some of the other PyAEDT contributors before we continue.
@maxcapodi78 or @MaxJPRey - can you review this draft PR and give your preliminary feedback before we proceed to polish the finer details?
…ed, linux tests skipped.
|
@Samuelopez-ansys who would be the right person to review this PR? It's still a draft and we will have more to refine, but wanted initial feedback on this draft. |
|
@Samuelopez-ansys I am looking for an architecture/design-level review while this is still a draft. The comments so far have been cosmetic. We'll work to address all the cosmetic issues, but some of that could be premature if any substantial architectural changes are needed (large amounts of code to add/remove/move). |
|
@myoung301 Ok I see. I will review the code on Monday then. |
|
@ramin4667 Please mark as resolved the conversations, if you fixed them. |
…/pyaedt into feat/draft_filtersolutions
for more information, see https://pre-commit.ci
_unittest/test_45_FilterSolutions/test_lumped_filter/test_lumped_nodes_and_leads.py
Outdated
Show resolved
Hide resolved
_unittest/test_45_FilterSolutions/test_lumped_filter/test_lumped_nodes_and_leads.py
Outdated
Show resolved
Hide resolved
_unittest/test_45_FilterSolutions/test_filter/test_attributes.py
Outdated
Show resolved
Hide resolved
[feat/drfat_filtersolutions] This new feature adds a draft release of FilterSolutions API to pyaedt platform.